Review Request 122672: Updates for project dependencies

Marko Käning mk-lists at email.de
Mon Feb 23 22:30:30 UTC 2015



> On Feb. 23, 2015, 12:38 a.m., Michael Pyne wrote:
> > Regarding empty entries in logical-module-structure, that's also a hint to kdesrc-build that the git repository in question should not be built at all for that branch-group. However kdesrc-build defaults to assuming `master` for unknown repositories, at least at this point. I doubt this would be a problem for stable-kf5-qt5 but I did want to emphasize that the default behavior appears to be different than the CI system's defaults.
> > 
> > I'll note that kde-build-metadata was actually introduced for kdesrc-build so I'd like to keep it functional in that regard at least :). We're far enough along with kde-built-metadata that it might make sense to change the default for kdesrc-build, such that modules simply don't appear at all in kdesrc-build unless they are properly defined in logical-module-structure.
> > 
> > As far as dependencies, I'm sure you know them better than I do. I took a look and didn't see anything obviously ridiculous, so you have that going for you. ;)
> 
> Ben Cooksley wrote:
>     With the problems being run into we probably need to work on getting the new specification pushed out I guess, as stating blank for everything without an explicit declaration might be a problem. 
>     
>     The Linux CI scripts follow the same behaviour as kdesrc-build here, in using "master" if explicitly asked to build something.
>     We don't have automated deployment at this stage, so we can't infer anything from a blank entry.
>     
>     I concur that this file needs to be kept generic for all tools to use.
> 
> Marko Käning wrote:
>     Thanks, Michael, for looking over it.
>     
>     Ben, do I have a "Ship it!" from you as well?
> 
> Ben Cooksley wrote:
>     As long as this doesn't break any existing builds, or cause Scarlett any problems, it is fine with me.

It shouldn't break any existing builds, instead enable new ones. OK, I'll contact Scarlett separately before committing to make sure.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122672/#review76441
-----------------------------------------------------------


On Feb. 22, 2015, 1:19 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122672/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 1:19 p.m.)
> 
> 
> Review request for KDE Websites, Albert Astals Cid, Ben Cooksley, David Faure, and Michael Pyne.
> 
> 
> Repository: kde-build-metadata
> 
> 
> Description
> -------
> 
> Hi folks,
> 
> herewith I want to suggest some changes to the CI system' build metadata:
> 
>  * remove empty stable-kf5-qt5 entries (isn't necessary for the CI due to empty default setting)
>  * update dependencies for a few newly introduced projects
> 
> Greets,
> Marko
> 
> 
> Diffs
> -----
> 
>   dependency-data-kf5-qt5 4757ca3b3c5b1930195c1fcb2f21ee6ffcd27890 
>   logical-module-structure 6bdabfee3d0f3d887d5633b9a776b7449649edc2 
> 
> Diff: https://git.reviewboard.kde.org/r/122672/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested on my OSX/CI system for branch groups kf5-qt5 and stable-kf5-qt5.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-www/attachments/20150223/ddd66d2e/attachment-0001.html>


More information about the kde-www mailing list