Review Request 116810: Code cleaning (and modularization) of reports_spec.rb

[yash ladia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116810/
-----------------------------------------------------------

(Updated July 14, 2014, 11:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Websites and Ben Cooksley.


Repository: reports-kde-org


Description
-------

I have split the reports_spec.rb (530 lines long) file into two files:
  1. news_reports_spec.rb (152 lines)
  2. project_reports_spec.rb (266 lines)
I have used the rspec feature of "shared examples" to reduce code duplication.
Also, I have removed some trailing whitespaces, changed few 'string' to "string" and removed some blank lines.

This patch has virtually no effect (except creating a few more users during testing) on the working of the code. It is just a code cleaning patch.


Diffs
-----

  spec/requests/news_reports_spec.rb PRE-CREATION 
  spec/requests/project_reports_spec.rb PRE-CREATION 
  spec/requests/reports_spec.rb 9cd9b4f 

Diff: https://git.reviewboard.kde.org/r/116810/diff/


Testing
-------

I have tested by running "bundle exec rspec" in both with and without this patch. The same results (87 examples, 70 failures, 16 pending) are obtained in both.


Thanks,

yash ladia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-www/attachments/20140714/ed89c1f2/attachment.html>