Broken EBN links on http://kde.org/applications/ development pages

[Burkhard Lück]

Am Dienstag, 20. September 2011, 12:43:43 schrieb Ingo Malchow:
> 2011/9/20 Burkhard Lück <lueck at hube-lueck.de>:
> > Am Dienstag, 20. September 2011, 11:12:42 schrieb Ingo Malchow:
> >> 2011/9/20 Burkhard Lück <lueck at hube-lueck.de>:
> >> > Hi
> >> > 
> >> > on the development pages on http://kde.org/applications/ all links to
> >> > the EBN checks (Code Checking / Documentation Sanitation) are broken,
> >> > 
> >> > How are these links generated and how to fix them?
> >> > 
> >> > --
> >> > Burkhard Lück
> >> 
> >> Hi Burkhard,
> >> 
> >> weirdly not every page seems to be broken from a quick look.
> > 
> > These pages seem to be not broken, just because the source code location
> > is wrong, in case of digikam the json file still has 'svn'. If I correct
> > that, the EBN links will be broken on digikam devel page as well.
> 
> Ok, that's not good... And from the look of it there doesn't seem to
> be a reliable path on projects.kde.org either...
> Needs some deeper investigation.
> 
> >> Anyway,
> >> to your question, the url gets build in hardcoded way (like "return
> >> 'http://englishbreakfastnetwork.org/krazy/reports/'.$this->ebnUrlBase().
> >> '/i ndex.html';") in media/includes/classes/class_appdata.inc
> >> An explanation could be there is no real specific url.
> >> http://kde.org/applications/graphics/digikam/development gives correct
> >> links, but amarok does not. if you know how to build the correct url
> >> just from an app name, that should be fairly simple to fix.
> > 
> > class_appdata.inc has only a function to build ebnUrlBase for svn
> > locations. There are only two hardcoded EBN urls for git repos, both
> > wrong
> > ("extragear/multimedia/amarok-git" -> "extragear/multimedia/amarok"
> > "extragear/network/konversation-git/" ->
> > "extragear/network/konversation").
> 
> Fixed according to your and Ben's information, thanks.
> 
Your fix needs an aditional fix:

function ebnDocCheckingUrl() 
   {
-        return 'http://ebn.org/sanitizer/reports/'.$this-
>ebnUrlBase().'/index.html';
+        return 'http://ebn.kde.org/sanitizer/reports/'.$this-
>ebnUrlBase().'/index.html';
   }

-- 
Burkhard Lück