[Craft] [Bug 453950] New: The MSBuild Craft build system crashes when the build time is MinSizeRel

[kdebugs at noahandrews.me]

https://bugs.kde.org/show_bug.cgi?id=453950

            Bug ID: 453950
           Summary: The MSBuild Craft build system crashes when the build
                    time is MinSizeRel
           Product: Craft
           Version: master
          Platform: Microsoft Windows
                OS: Microsoft Windows
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: Core
          Assignee: vonreth at kde.org
          Reporter: kdebugs at noahandrews.me
                CC: kde-windows at kde.org
  Target Milestone: ---

SUMMARY
When trying to build KDE Connect on Windows using MSVC for the first time, the
build failed because liblzma apparently specified a build type of MinSizeRel,
which the MSBuild build system does not support.

STEPS TO REPRODUCE
1. Follow the steps to install Craft and build KDE Connect on Windows using
MSVC: https://community.kde.org/KDEConnect/Build_Windows

OBSERVED RESULT

Relevant log output:

*** Handling package: libs/liblzma, action: all ***
*** Action: fetch-binary for libs/liblzma ***
Could not find libs/liblzma=5.2.3 in
https://files.kde.org/craft/master/22.05/windows/msvc2019_64/cl/MinSizeRel
*** libs/liblzma not found in cache ***
*** Action: fetch for libs/liblzma ***
*** Action: unpack for libs/liblzma ***
Please enable Windows 10 development mode to enable support for symlinks.
This will enable faster extractions.
https://docs.microsoft.com/en-us/windows/uwp/get-started/enable-your-device-for-development
*** Action: compile for libs/liblzma ***
entering the source directory!
*** Craft all succeeded: libs/liblzma after 0 seconds ***
'MinSizeRel'
Traceback (most recent call last):
  File "C:\CraftRoot\craft\bin\craft.py", line 274, in <module>
    success = main(timer)
  File "C:\CraftRoot\craft\bin\craft.py", line 264, in main
    if not CraftCommands.run(package, action, tempArgs):
  File "C:\CraftRoot\craft\bin\CraftCommands.py", line 425, in run
    if not handlePackage(info, action, directTargets=directTargets):
  File "C:\CraftRoot\craft\bin\CraftCommands.py", line 94, in handlePackage
    success = doExec(package, action)
  File "C:\CraftRoot\craft\bin\CraftCommands.py", line 58, in doExec
    ret = package.instance.runAction(action)
  File "C:\CraftRoot\craft\bin\Package\PackageBase.py", line 247, in runAction
    if not getattr(self, step)():
  File "C:\CraftRoot\craft\bin\BuildSystem\BuildSystemBase.py", line 89, in
compile
    return configure() and make()
  File "C:\CraftRoot\craft\bin\BuildSystem\MSBuildBuildSystem.py", line 46, in
make
    buildType =self.buildTypes[self.buildType()]
KeyError: 'MinSizeRel'


EXPECTED RESULT

The software should build successfully

SOFTWARE/OS VERSIONS
Windows: Windows 11 Pro 21H2

-- 
You are receiving this mail because:
You are on the CC list for the bug.