[Craft] [Bug 456452] New: Craft blueprint qtbase fails to build on macOS when using the Qt Patch Collection

[Javier O. Cordero Pérez]

https://bugs.kde.org/show_bug.cgi?id=456452

            Bug ID: 456452
           Summary: Craft blueprint qtbase fails to build on macOS when
                    using the Qt Patch Collection
           Product: Craft
           Version: stable
          Platform: macOS (DMG)
                OS: macOS
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: Blueprints
          Assignee: vonreth at kde.org
          Reporter: javiercorderoperez at gmail.com
                CC: kde-windows at kde.org
  Target Milestone: ---

SUMMARY
qtbase blueprint fails to build on macOS when libs/qt5 version is set to
kde/5.15. 

STEPS TO REPRODUCE
1. Create and start a new Craft environment on an x86_64 system that runs
macOS:
> curl https://raw.githubusercontent.com/KDE/craft/master/setup/CraftBootstrap.py -o setup.py && python3 setup.py --prefix ~/CraftRoot
> source /Users/javier/CraftRoot/craft/craftenv.sh
2. Configure Craft to use KDE's Qt Patch Collection
> craft --set version=kde/5.15 libs/qt5
3. Build qtbase
> craft libs/qt5/qtbase

OBSERVED RESULT
The Patch Collection's version fails to evaluate correctly in the following
lines:
>128            if self.qtVer >= "5.14":
>129                mac_required = "10.13"
>130            elif self.qtVer >= "5.12":
>131                mac_required = "10.12"

Resulting in mac_required being undefined when accessed in line 132:
>132            if not CraftVersion(os.environ["MACOSX_DEPLOYMENT_TARGET"]) >= mac_required:

EXPECTED RESULT
1. self.qtVer should be sanitized, such that self.qtVer >= "5.14" holds true
for kde/5.15.
2. An else condition is set, preventing mac_required from ever being undefined.

SOFTWARE/OS VERSIONS
macOS: Big Sur 11.6 (x86_64)
Qt Version: 5.15.5 kde-patched

-- 
You are receiving this mail because:
You are on the CC list for the bug.