[kxmlgui] autotests: autotests: mark known test failure with QEXPECT_FAIL

David Faure null at kde.org
Sun Feb 2 09:49:02 GMT 2020


Git commit 5eae4d970306d222df338a2459bc4bcf4646d0dc by David Faure.
Committed on 02/02/2020 at 09:48.
Pushed by dfaure into branch 'master'.

autotests: mark known test failure with QEXPECT_FAIL

A Windows developer needs to implement this feature (switching language
on the fly) on Windows. Any takers?

Meanwhile I'd like to be able to detect regressions in CI, this isn't
one.
CCMAIL: kde-windows at kde.org

M  +3    -0    autotests/kxmlgui_unittest.cpp

https://commits.kde.org/kxmlgui/5eae4d970306d222df338a2459bc4bcf4646d0dc

diff --git a/autotests/kxmlgui_unittest.cpp b/autotests/kxmlgui_unittest.cpp
index e95ac7b..77ef771 100644
--- a/autotests/kxmlgui_unittest.cpp
+++ b/autotests/kxmlgui_unittest.cpp
@@ -1085,6 +1085,9 @@ void KXmlGui_UnitTest::testSpecificApplicationLanguageQLocale()
     KDEPrivate::setApplicationSpecificLanguage("ru_RU");
     KDEPrivate::initializeLanguages();
 
+#ifdef Q_OS_WIN
+    QEXPECT_FAIL("", "KDEPrivate::initializeLanguages assumes that setting $LANGUAGE will have an effect, this isn't the case on Windows. Needs to be fixed.", Abort);
+#endif
     QCOMPARE(QLocale::system().language(), QLocale::Russian);
 
     KDEPrivate::setApplicationSpecificLanguage("wa");


More information about the Kde-windows mailing list