ecm_add_app_icon() does not work as expected on Windows

[Christoph Cullmann]

Hi,

thanks for tracking this down!

Will try to fix the CMake stuff.

Greetings
Christoph

On 2019-12-16 21:54, Alexander Potashev wrote:
> пн, 16 дек. 2019 г. в 22:01, Alexander Potashev <aspotashev at gmail.com>:
>> 
>> вс, 15 дек. 2019 г. в 21:20, Alexander Potashev 
>> <aspotashev at gmail.com>:
>> > However my problem with ecm_add_app_icon() did not go away, it's
>> > probably unrelated. I attach a screenshot of what Kate and KWrite
>> > icons look like after a fresh rebuild with "craft -i --target master
>> > kate".
>> 
>> I tried the today's nightly build of KTimeTracker
>> https://binary-factory.kde.org/job/KTimeTracker_Nightly_win64/4/ , and
>> it's also missing the icon embedded ktimetracker.exe.
>> 
>> Then I went further and tried several Windows installer for Kate from
>> KDE Binary Factory. All the available nightly builds [1,2,3] and
>> today's 19.12.0 release build [4] don't have icons in kate.exe, at
>> least Windows 10 does not detect it. The 19.08.2 release builds'
>> kate.exe has icon, see e.g. [5].
>> 
>> [1] https://binary-factory.kde.org/job/Kate_Nightly_win64/661/
>> [2] https://binary-factory.kde.org/job/Kate_Nightly_win64/664/
>> [3] https://binary-factory.kde.org/job/Kate_Nightly_win64/665/
>> [4] https://binary-factory.kde.org/job/Kate_Release_win64/706/
>> [5] https://binary-factory.kde.org/job/Kate_Release_win64/705/
> 
> Case solved: it's a regression in Kate, see
> https://bugs.kde.org/show_bug.cgi?id=415260

-- 
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org