Patch for unwanted console windows caused by KIO slaves [Fwd: Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC]

[Kevin Funk]

On Monday, 10 October 2016 22:56:11 CEST Jaroslaw Staniek wrote:
> On 11 July 2016 at 18:20, Kevin Funk <kfunk at kde.org> wrote:
> > Heya,
> > 
> > we used to have this problem where KIO slaves forked off from a process
> > caused
> > console windows to pop up on Windows.
> > 
> > This is now resolved.
> > 
> > All started here:
> >   https://git.reviewboard.kde.org/r/124905/
> > 
> > ... then ended up in a Qt bug report (which got fixed by me later on):
> >   https://bugreports.qt.io/browse/QTBUG-53833
> > 
> > Patch here:
> >   https://codereview.qt-project.org/#/c/162585/
> > 
> > tl;dr: Fixed in Qt 5.8.0.
> 
> ​
> Hi Kevin

Heya,

> After a while: I think forcing to skip Qt LTS and going for 5.8.0 is not
> practical.

Well, you can always patch Qt? 

> Are users of KIO and alike forced to patch KF5 to remove unwanted "black
> windows"?

Emerge applies that patch to qtbase already. So when you use Emerge, your 
issue is fixed.

Regarding upstream: I didn't push it to anything below Qt 5.8 b/c it's a 
behavioral change after all. Not a simple bug fix.

> That would look like unfortunate for developer experience of KF5 on Windows.
> That's what exactly I am facing (and in fact migrating away from dbus too,
> thus decreasing my use of KF5 unfortunately on Windows).
 
> Can we have a temporary fix at ECM of KF5 level (e.g. for Qt < 5.8.0)?

I'm lacking the motivation/time do so unfortunately. I've already spent 
significant amount of my time on this issue, not planning to continue.

Regards,
Kevin

> > The qtbase recipe in emerge.git contains a patch, which is automatically
> > applied before the build happens.
> > 
> > Cheers,
> > Kevin
> > 
> > ----------  Forwarded Message  ----------
> > 
> > Subject: Re: Review Request 124905: Win: Hide console window for binaries
> > in
> > LIBEXEC
> > Date: Monday, July 11, 2016, 4:15:00 PM CEST
> > From: Kevin Funk <kfunk at kde.org>
> > To: Alex Merry <alex.merry at kde.org>, David Faure <faure at kde.org>
> > CC: KDE Frameworks <kde-frameworks-devel at kde.org>, Patrick Spendrin
> > <ps_ml at gmx.de>, Kevin Funk <kfunk at kde.org>, Gleb Popov <6yearold at gmail.com
> > 
> > 
> > 
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/124905/
> > -----------------------------------------------------------
> > 
> > (Updated July 11, 2016, 4:15 p.m.)
> > 
> > 
> > Status
> > ------
> > 
> > This change has been discarded.
> > 
> > 
> > Review request for KDE Frameworks, Alex Merry and David Faure.
> > 
> > 
> > Repository: kio
> > 
> > 
> > Description
> > -------
> > 
> > Win: Hide console window for binaries in LIBEXEC
> > 
> > 
> > Diffs
> > -----
> > 
> >   src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d
> > 
> > 1ef6fb5cfc
> > 
> >   src/ioslaves/http/kcookiejar/CMakeLists.txt
> > 
> > 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365
> > 
> >   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608
> >   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e
> >   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc
> > 
> > Diff: https://git.reviewboard.kde.org/r/124905/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Kevin Funk
> > 
> > 
> > -----------------------------------------
> > --
> > Kevin Funk | kfunk at kde.org | http://kfunk.org
> > _______________________________________________
> > Kde-windows mailing list
> > Kde-windows at kde.org
> > https://mail.kde.org/mailman/listinfo/kde-windows


-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20161010/8dc0c40f/attachment.sig>