Review Request 127424: KCompletionBox popup gets full window decoration on Windows

[Martin Gräßlin]

> On March 24, 2016, 8:45 p.m., Dominik Haumann wrote:
> > Given the feedback I got, I will submit tomorrow (Friday), independent on whether I have a ship-it or not.
> > The patch is tested both on Windows and Linux, and imo correct (the changes are rather trivial now).
> > 
> > If you have objections, please raise them by tomorrow, or better yet, do a review - thanks.
> > 
> > PS: I am totally aware that typically a ship-it is the way to get a patch accepted, but I have the feeling this patch is not getting much attention, despite me trying to get input for days.

I think you didn't get a ship-it as nobody is confident enough to say that it's correct on all platforms. I'm quite certain that on X11 the behavior is correct.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93943
-----------------------------------------------------------


On March 20, 2016, 1:06 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 1:06 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are not forwarded, so typing is not possible, and additionally, on losing focus the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -----
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> -------
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> ----------------
> 
> Completion Popup
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160325/2b38894e/attachment.html>