Review Request 127239: NSIS Packager: Include distributable runtime for older versions of MSVC, too

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127239/#review92977
-----------------------------------------------------------


Fix it, then Ship it!




Rest LGTM, great work!


bin/Packager/NullsoftInstallerPackager.py (line 151)
<https://git.reviewboard.kde.org/r/127239/#comment63407>

    Factor out to separate function as well? I.e. `getVCRuntimeLibrariesLocation`?


- Kevin Funk


On March 1, 2016, 9:16 a.m., Thomas Friedrichsmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127239/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 9:16 a.m.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> NSIS Packager has code to include the VC redistributable libs for MSVC 2015. This patch does two things:
> 
> a) Try to support non-standard installation directories of MSVC. It does this by locating cl.exe, then using relative paths from that. Since somehow emerge is capable of finding my install of MSVC 2013 in a non-standard location, before it is in the path, I assume a more elegant way does exist. Unfortunately, I have not been able to find out how that is done. Arguably, though, the solution suggested, here, is still _more_ elegant than using a hard-coded (default) installation path.
> 
> b) Include the redistributable libs for older MSVC in the package, too. MSVC 2013 does not appear to ship vc_redist[arch].exe, so I'm doing that by copying the libs from VC's redist folder to the "bin" folder of the archive.
> 
> For the moment, the code will bail out with an error message for MinGW, as it there is little point in producing installers installing non-runnable applications. It should be rather straightforward to add a solution along the lines of b) for MinGW, too, however.
> 
> 
> Diffs
> -----
> 
>   bin/Packager/NullsoftInstallerPackager.py 7155f800b916714bcaf370f501b101650c1302bc 
> 
> Diff: https://git.reviewboard.kde.org/r/127239/diff/
> 
> 
> Testing
> -------
> 
> Tested with MSVC 2013 for RKWard. Installer is created successfully, and the installed application is runnable (while it was not, without the patch).
> 
> _Not_ tested with MSVC 2015.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160301/c05309c5/attachment.html>