Patch for unwanted console windows caused by KIO slaves [Fwd: Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC]

Mon Jul 11 21:42:17 UTC 2016

On Monday, July 11, 2016 8:14:06 PM CEST Jasem Mutlaq wrote:
> > You need to explain / re-phrase that.
> > 
> > So you start $mainapp, close $mainapp, and $mainapp stays open?
> > 
> > If that's the case, yes: completely different bug.
> 
> Yes. I just tested it by launching KStars on Windows 10 64bit. I then used
> "Get Hot New Stuff" to download an item. In the task manager, I see three
> kioslaves.exe and one kio_http_cache_cleaner.exe. I then close KStars, and
> in the task manager, I still see kstars.exe in the task manager. All of
> them have status as "Running". If I launch KStars again and repeat the same
> process, it leaves another zombie process there as well and keep piling up
> with each launch.

Yes, I think we already talked about this in #kde-windows, didn't we?

Known issue. We currently have a few hang-on-exit problems, probably due to 
way DBus handling changed in recent Qt.

dfaure already fixed one of the issues:
  https://phabricator.kde.org/D1909

For me, kdevelop.exe right now hangs here, on exit:

Stack trace:

    ntdll.dll!NtWaitForSingleObject()  Unknown
    KernelBase.dll!WaitForSingleObjectEx() Unknown
>   Qt5Core.dll!QWaitCondition::wait(QMutex * mutex=0x000001e2ae2edbf0, 
unsigned long time=4294967295) Line 178 C++
    Qt5Core.dll!QSemaphore::acquire(int n=1) Line 136   C++
    Qt5Core.dll!QMetaObject::activate(QObject * sender=0x000001e2a7809450, int 
signalOffset, int local_signal_index, void * * argv=0x00000031c07af0d0) Line 
3699    C++
    Qt5Core.dll!QObject::~QObject() Line 913    C++
    KF5GlobalAccel.dll!00007fff3101a115()   Unknown
    Qt5Core.dll!QObjectPrivate::deleteChildren() Line 1960  C++
    Qt5Core.dll!QObject::~QObject() Line 1034   C++
    KF5GlobalAccel.dll!00007fff31036670()   Unknown
    ucrtbase.dll!_time64() Unknown
    ucrtbase.dll!__crt_seh_guarded_call<int>::operator()<class 
<lambda_e24bbb7b643b32fcea6fa61b31d4c984>,class 
<lambda_275893d493268fdec8709772e3fcec0e> &,class 
<lambda_9d71df4d7cf3f480f8d633942495c3b0> >(class 
<lambda_e24bbb7b643b32fcea6fa61b31d4c984> &&,class 
<lambda_275893d493268fdec8709772e3fcec0e> &,class 
<lambda_9d71df4d7cf3f480f8d633942495c3b0> &&)   Unknown
    ucrtbase.dll!_execute_onexit_table()   Unknown
    KF5GlobalAccel.dll!00007fff3102df62()   Unknown
    KF5GlobalAccel.dll!00007fff3102e09e()   Unknown
    ntdll.dll!LdrpCallInitRoutine() Unknown
    ntdll.dll!LdrShutdownProcess()  Unknown
    ntdll.dll!RtlExitUserProcess()  Unknown
    kernel32.dll!ExitProcessImplementation()   Unknown
    ucrtbase.dll!swprintf()    Unknown
    ucrtbase.dll!swprintf()    Unknown
    kdevelop.exe!__scrt_common_main_seh() Line 266  C++
    kernel32.dll!BaseThreadInitThunk() Unknown
    ntdll.dll!RtlUserThreadStart()  Unknown

> Regards,
> Jasem
> 
> > Regards,
> > Kevin
> > 
> > > Is this fixed as well or
> > > another issue completely?
> > > 
> > > Regards,
> > > Jasem
> > > 
> > > On Mon, Jul 11, 2016 at 7:20 PM, Kevin Funk <kfunk at kde.org> wrote:
> > > > Heya,
> > > > 
> > > > we used to have this problem where KIO slaves forked off from a
> > > > process
> > > > caused
> > > > console windows to pop up on Windows.
> > > > 
> > > > This is now resolved.
> > > > 
> > > > All started here:
> > > >   https://git.reviewboard.kde.org/r/124905/
> > > > 
> > > > ... then ended up in a Qt bug report (which got fixed by me later on):
> > > >   https://bugreports.qt.io/browse/QTBUG-53833
> > > > 
> > > > Patch here:
> > > >   https://codereview.qt-project.org/#/c/162585/
> > > > 
> > > > tl;dr: Fixed in Qt 5.8.0.
> > > > 
> > > > The qtbase recipe in emerge.git contains a patch, which is
> > 
> > automatically
> > 
> > > > applied before the build happens.
> > > > 
> > > > Cheers,
> > > > Kevin
> > > > 
> > > > ----------  Forwarded Message  ----------
> > > > 
> > > > Subject: Re: Review Request 124905: Win: Hide console window for
> > 
> > binaries
> > 
> > > > in
> > > > LIBEXEC
> > > > Date: Monday, July 11, 2016, 4:15:00 PM CEST
> > > > From: Kevin Funk <kfunk at kde.org>
> > > > To: Alex Merry <alex.merry at kde.org>, David Faure <faure at kde.org>
> > > > CC: KDE Frameworks <kde-frameworks-devel at kde.org>, Patrick Spendrin
> > > > <ps_ml at gmx.de>, Kevin Funk <kfunk at kde.org>, Gleb Popov <
> > 
> > 6yearold at gmail.com
> > 
> > > > -----------------------------------------------------------
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://git.reviewboard.kde.org/r/124905/
> > > > -----------------------------------------------------------
> > > > 
> > > > (Updated July 11, 2016, 4:15 p.m.)
> > > > 
> > > > 
> > > > Status
> > > > ------
> > > > 
> > > > This change has been discarded.
> > > > 
> > > > 
> > > > Review request for KDE Frameworks, Alex Merry and David Faure.
> > > > 
> > > > 
> > > > Repository: kio
> > > > 
> > > > 
> > > > Description
> > > > -------
> > > > 
> > > > Win: Hide console window for binaries in LIBEXEC
> > > > 
> > > > 
> > > > Diffs
> > > > -----
> > > > 
> > > >   src/ioslaves/http/CMakeLists.txt
> > > >   76a8e2800b84c312431cc1996ac81d1ef6fb5cfc
> > > >   src/ioslaves/http/kcookiejar/CMakeLists.txt
> > > > 
> > > > 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365
> > > > 
> > > >   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608
> > > >   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e
> > > >   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc
> > > > 
> > > > Diff: https://git.reviewboard.kde.org/r/124905/diff/
> > > > 
> > > > 
> > > > Testing
> > > > -------
> > > > 
> > > > 
> > > > Thanks,
> > > > 
> > > > Kevin Funk
> > > > 
> > > > 
> > > > -----------------------------------------
> > > > --
> > > > Kevin Funk | kfunk at kde.org | http://kfunk.org
> > > > _______________________________________________
> > > > Kde-windows mailing list
> > > > Kde-windows at kde.org
> > > > https://mail.kde.org/mailman/listinfo/kde-windows
> > 
> > --
> > Kevin Funk | kfunk at kde.org | http://kfunk.org

-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160711/878a6304/attachment.sig>