Review Request 127187: Fix build for MSVC (2013) on Windows

Mon Feb 29 15:07:02 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127187/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 3:07 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks, kdewin and Ivan Čukić.

Repository: kactivities

Description
-------

MSVC (2013) complains that beginResetModel(), etc. are protected. This patch allows the code to compile. It is clearly not very elegant, but both my templating- and MSVC-foo is extremely limited. Not sure, if there is a better fix.

Diffs
-----

  src/lib/activitiesmodel.h 7258b73 
  src/lib/activitiesmodel.cpp af30f59 
  src/lib/activitiesmodel_p.h dfa861b 
  src/utils/model_updaters.h ae8e279 

Diff: https://git.reviewboard.kde.org/r/127187/diff/

Testing
-------

Now compiles with MSVC 2013 on Windows.

Thanks,

Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160229/d39bb00c/attachment-0001.html>