Review Request 127177: Compilation fixes for MSVC (2013)

Thomas Friedrichsmeier thomas.friedrichsmeier at
Fri Feb 26 14:14:02 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 26, 2016, 2:14 p.m.)


This change has been marked as submitted.

Review request for KDE Frameworks and kdewin.


Submitted with commit 1c2aa25fb179fe3350bee166f2d8e69404d0cc7f by Thomas Friedrichsmeier to branch master.

Repository: ki18n


Fix compilation on Windows with MSVC.

a) MSVC accepts declspec at global scope, only.
b) QStringLiteral does not work with concatenated literals in MSVC (see Since the occurences seem to be mostly for debugging, going through QString::fromLatin1() in these cases should not hurt much.


  src/kcatalog.cpp 083443d 
  src/ktranscript.cpp 72c3755 



Now builds with MSVC 2013.

No other compilers and no other platforms tested for this patch.


Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-windows mailing list