Pull Request:- pull_req

Kevin Funk kfunk at kde.org
Tue Aug 30 11:11:37 UTC 2016


On Monday, 29 August 2016 16:25:53 CEST Vibhor Verma wrote:
> Dear Sir,
> 
> I added a small feature to powershell script file setup/install_emerge.ps1
> that if the *installRoot* exists in the location we are installing emerge.
> 
> Then user get 3 options:-
> 
>    1. Truncate installRoot and install emerge in it.
>    2. Change installRoot location. It also proposes new directory name as
>    default with suffix string "*(1)*" to the user.For Example:- if
>    installRoot chosen is *d:\kderoot*, then it will propose new directory
>    name as *d:\kderoot(1)*.
>    3. Quit installation.
> 
> I have explained about the changes I made. Expecting comments or feedback
> about the change i made whether the changes made are fine or they are not
> right as it is *my first contribution to opensource and to kde* and so that
> i could improve next time.

Heya,

Where's the patch you're mentioning?

Please upload your patch to KDE infrastructure so we can discuss.

See:
  https://community.kde.org/Get_Involved/
development#Submitting_your_first_patch

Thanks,
Kevin

> Expecting a prompt reply from your side.
> 
> Regards
> 
> Vibhor Verma


-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160830/f73487b8/attachment.sig>


More information about the Kde-windows mailing list