Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

Andrius da Costa Ribas andriusmao at gmail.com
Sat Apr 23 17:46:27 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/
-----------------------------------------------------------

Review request for KDE Frameworks and kdewin.


Repository: kcoreaddons


Description
-------

Although there is currently no problem on building kcoreaddons, when building okular (and possibly other apps) the compiler gets confused when it reaches std::numeric_limits<uint>::max() as <windows.h> is also included and it defines a 'max' macro.


Diffs
-----

  src/lib/util/kuser.h 3c9ff00 

Diff: https://git.reviewboard.kde.org/r/127729/diff/


Testing
-------

Okular is buildable on MSVC after this patch. No further testing done.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160423/76b9300f/attachment.html>


More information about the Kde-windows mailing list