Review Request 127714: Enable ICO and EXE thumbnails again.

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
-----------------------------------------------------------

(Updated Abril 22, 2016, 7:55 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
-------

Added screenshots (note: Icoutils version doesn't support all icon formats).


Repository: kio-extras


Description
-------

These had been disabled when moving into frameworks.


Diffs
-----

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
-------

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working (with wrestool binary from (**aaargh!!**) cygwin).


File Attachments (updated)
----------------

Native Version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160422/328c4409/attachment.html>