Review Request 125401: implement windows usermetadata

[Vishesh Handa]

> On Sept. 26, 2015, 10:52 a.m., Vishesh Handa wrote:
> > I cannot really comment on the windows parts. But the ideas seems good. Ship it?
> 
> Patrick Spendrin wrote:
>     Since I moved code around for *nix as well, could you check that it compiles at least (and maybe also works as before)? Otherwise I'll push it tomorrow...

Compiles on Linux, all tests pass, and basic adding, listing and modifying xattr seems to work.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125401/#review85951
-----------------------------------------------------------


On Sept. 27, 2015, 11:17 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125401/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2015, 11:17 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> I implemented all the functions for storing and retrieving user metadata
> using Alternate Data Streams (ADS).
> 
> 
> Diffs
> -----
> 
>   src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 
>   src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 
>   src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba 
>   src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 
> 
> Diff: https://git.reviewboard.kde.org/r/125401/diff/
> 
> 
> Testing
> -------
> 
> On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for other platforms
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150927/3863a87a/attachment.html>