Review Request 125574: Fix compilation of kjs under MSVC2015

Gleb Popov 6yearold at gmail.com
Sun Oct 11 16:59:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125574/#review86667
-----------------------------------------------------------


I was faster with this: https://git.reviewboard.kde.org/r/125582/

- Gleb Popov


On Oct. 10, 2015, 12:04 a.m., Michael Drueing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125574/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 12:04 a.m.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: kjs
> 
> 
> Description
> -------
> 
> MSVC doesn't use `_timezone` but `timezone` (as seen on lines 91+ in `date_object.cpp`)
> 
> 
> Diffs
> -----
> 
>   src/kjs/date_object.cpp add2cea 
> 
> Diff: https://git.reviewboard.kde.org/r/125574/diff/
> 
> 
> Testing
> -------
> 
> Changing `timezone` to `_timezone` as per the patch makes kjs compile on MSVC2015
> 
> 
> Thanks,
> 
> Michael Drueing
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20151011/659b8c46/attachment.html>


More information about the Kde-windows mailing list