Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86615
-----------------------------------------------------------



portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (line 8)
<https://git.reviewboard.kde.org/r/125580/#comment59623>

    This shouldn't be removed, because it might still be needed in other versions...



portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (line 34)
<https://git.reviewboard.kde.org/r/125580/#comment59624>

    This should go into the default buildsystem as if(MSVC)
        add_definitions(-DWIN32_LEAN_AND_MEAN)
    endif()
    
    I think.


- Patrick Spendrin


On Okt. 10, 2015, 9:13 vorm., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> -----------------------------------------------------------
> 
> (Updated Okt. 10, 2015, 9:13 vorm.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> I've had to put #include <algorithm> everywhere, not sure if it is a right thing to do.
> 
> 
> Diffs
> -----
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20151010/423b8227/attachment.html>