Review Request 117829: do not raise unknown signal on windows

[Vishesh Handa]

> On April 28, 2014, 12:42 p.m., Vishesh Handa wrote:
> > src/file/autotest/fileindexingjob/extractor.cpp, line 76
> > <https://git.reviewboard.kde.org/r/117829/diff/1/?file=268894#file268894line76>
> >
> >     Wouldn't exit just terminate the process normally? I was hoping to simulate a crash.
> 
> Michael Pyne wrote:
>     If you want to simulate a crash portably, you might want to try abort(3), which is available in C since C89. I'm not sure what it does on Windows, but on POSIX it throws SIGABRT instead but that should be easy enough to adjust to.
> 
> Vishesh Handa wrote:
>     ping?
> 
> Vishesh Handa wrote:
>     ping?

I'm closing this review for now.  Please feel free to re-open it or file a new one.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/#review56738
-----------------------------------------------------------


On April 28, 2014, 9:54 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117829/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 9:54 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> this signal is not available on windows. Also exit should behave in a similar way, so maybe exit can be used everywhere?
> 
> 
> Diffs
> -----
> 
>   src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 
> 
> Diff: https://git.reviewboard.kde.org/r/117829/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150204/921a3e49/attachment.html>