Review Request 124868: Use macro for include selection.

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124868/
-----------------------------------------------------------

(Updated Aug. 23, 2015, 6:55 p.m.)


Status
------

This change has been discarded.


Review request for kdewin and Kevin Funk.


Repository: kdewin


Description
-------

Put the logic for selecting proper inclusion path into a single file and use it from other headers.


Diffs
-----

  include/msvc/common.h PRE-CREATION 
  include/msvc/ctype.h ac53ca6 
  include/msvc/errno.h 5b6719f 
  include/msvc/fcntl.h e775e1c 
  include/msvc/math.h c17fd88 
  include/msvc/signal.h ee00c51 
  include/msvc/stdio.h 3431391 
  include/msvc/stdlib.h 7dd4102 
  include/msvc/string.h 9ee1403 
  include/msvc/sys/stat.h 8d1891d 
  include/msvc/sys/types.h dad9c44 
  include/msvc/time.h 8b91112 
  include/msvc/utime.h ff53ae6 
  include/msvc/wchar.h 45b437f 
  tests/CMakeLists.txt 83aff37 
  tests/includes.c PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124868/diff/


Testing
-------

Added tests/headers.c that includes all system headers provided by kdewin. This would allow detecting breakages in next MSVC versions.

Successfully compiled kdelibs4support with this patch.


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150823/c1d4f025/attachment.html>