Review Request 124847: add COMMON_HEADER option and multiple header functionality

Alex Merry alex.merry at kde.org
Sat Aug 22 10:07:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124847/#review84181
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Aug. 20, 2015, 9:04 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124847/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:04 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, kdewin, and Allen Winter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This adds a new keyword COMMON_HEADER which generates a new header
> containing all other headers. Also it is possible now to have multiple
> dummy headers per header file. It is assumed that the first header is the
> existing one.
> This patch has been developed originally for kdsoap / kdreports.
> 
> 
> Diffs
> -----
> 
>   modules/ECMGenerateHeaders.cmake b6290223cdf696968637b75f66217abcd680b3e2 
>   tests/ECMGenerateHeadersTest/CommonHeader PRE-CREATION 
>   tests/ECMGenerateHeadersTest/headtest4.h PRE-CREATION 
>   tests/ECMGenerateHeadersTest/run_test.cmake.config 1db623b7349d72ff3e90dcb274d9a0c8cba8dab0 
> 
> Diff: https://git.reviewboard.kde.org/r/124847/diff/
> 
> 
> Testing
> -------
> 
> Windows and Linux
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150822/5ffee9a3/attachment-0001.html>


More information about the Kde-windows mailing list