Review Request 124818: Fix update-mime-database crash.

arrowdodger arrowdodger 6yearold at gmail.com
Thu Aug 20 09:34:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124818/
-----------------------------------------------------------

(Updated Aug. 20, 2015, 12:34 p.m.)


Review request for kdewin.


Repository: emerge


Description
-------

VS was picking wrong function types for opendir/readdir because there was no prototypes for them in dirent.h, which lead to crash.
The second crash was due to writing 8-byte intptr_t value returned by _findfirst() into a 4-byte long variable.
No idea how it was working before.


Diffs (updated)
-----

  portage/win32libs/shared-mime-info/dirent.h b98296a 
  portage/win32libs/shared-mime-info/dirent.c 2ca945a 
  portage/win32libs/shared-mime-info/kdewin_export.h PRE-CREATION 
  portage/win32libs/shared-mime-info/lock.h PRE-CREATION 
  portage/win32libs/shared-mime-info/shared-mime-info.py 6eda428 

Diff: https://git.reviewboard.kde.org/r/124818/diff/


Testing
-------


Thanks,

arrowdodger arrowdodger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150820/ce299014/attachment.html>


More information about the Kde-windows mailing list