Review Request 124818: Fix update-mime-database crash.

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124818/#review84066
-----------------------------------------------------------


it worked under 32bit, and worked on Linux. I haven't seen the crash on x64 though, so maybe you can describe it a bit more?

- Patrick Spendrin


On Aug. 19, 2015, 1:42 nachm., arrowdodger arrowdodger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124818/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 1:42 nachm.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> VS was picking wrong function types for opendir/readdir because there was no prototypes for them in dirent.h, which lead to crash.
> The second crash was due to writing 8-byte intptr_t value returned by _findfirst() into a 4-byte long variable.
> No idea how it was working before.
> 
> 
> Diffs
> -----
> 
>   portage/win32libs/shared-mime-info/dirent.h b98296a 
>   portage/win32libs/shared-mime-info/dirent.c 2ca945a 
> 
> Diff: https://git.reviewboard.kde.org/r/124818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> arrowdodger arrowdodger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150819/f3bc088f/attachment.html>