Review Request 124749: Add debug and release options for Boost

Patrick von Reth vonreth at kde.org
Sun Aug 16 11:58:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124749/#review83874
-----------------------------------------------------------

Ship it!


Besides the one issue it looks great.


bin/BuildSystem/BoostBuildSystem.py (line 35)
<https://git.reviewboard.kde.org/r/124749/#comment58098>

    please use compiler.isX64()


- Patrick von Reth


On Aug. 15, 2015, 10:22 p.m., Michael Abrahams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124749/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 10:22 p.m.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> These additions are part of my recent work building Krita to Windows with KDE Frameworks 5.
> 
> 
> Diffs
> -----
> 
>   bin/BuildSystem/BoostBuildSystem.py fc18946 
> 
> Diff: https://git.reviewboard.kde.org/r/124749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Abrahams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150816/ffb70241/attachment.html>


More information about the Kde-windows mailing list