Review Request 120366: variable length arrays can't be static on windows

Kevin Funk kfunk at kde.org
Thu Sep 25 16:22:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120366/#review67439
-----------------------------------------------------------


Seems like alloca is the way to go to fake VLA: http://stackoverflow.com/questions/5246900/enabling-vlasvariable-length-arrays-in-ms-visual-c (it's also available on Linux)

- Kevin Funk


On Sept. 25, 2014, 2:03 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120366/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 2:03 p.m.)
> 
> 
> Review request for KDevelop, kdewin and Miquel Sabaté Solà.
> 
> 
> Repository: kdev-ruby
> 
> 
> Description
> -------
> 
> variable length arrays can't be static on windows, so we use malloc/free instead. Since I am not sure if this is suitable and if there is a better way around this restriction, I want you to review this.
> 
> 
> Diffs
> -----
> 
>   parser/parser.y 56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 
> 
> Diff: https://git.reviewboard.kde.org/r/120366/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2013
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140925/2327fb66/attachment.html>


More information about the Kde-windows mailing list