Review Request 120649: Encode the URIs which end up in DTD files

Luigi Toscano luigi.toscano at
Mon Oct 20 00:13:28 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 20, 2014, 2:13 a.m.)

Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.


Updated as the twin request

Repository: kdelibs4support


The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.

The function is duplicated from the matching functions in kdoctools
- this module will go away in the not far future;
- the function is not generic enough to be used outside (yet)

See also for the twin review on kdoctools.

Diffs (updated)

  cmake/uriencode.cmake PRE-CREATION 
  src/CMakeLists.txt 4a1d80d 



It compiles, but I can't properly test Mac and Windows scenarios


Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-windows mailing list