Review Request 121083: Replace manual export files with CMake's generate_export_header

Andrius da Costa Ribas andriusmao at gmail.com
Fri Nov 21 22:44:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
-----------------------------------------------------------

(Updated Nov. 21, 2014, 10:44 p.m.)


Review request for kde-workspace and kdewin.


Repository: oxygen


Description
-------

These files currently use  

```
__attribute__((visibility("...")))
```

which doesn't work on MSVC.


Diffs (updated)
-----

  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 
  liboxygen/CMakeLists.txt 69b7bd2 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
-------

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20141121/e13e784c/attachment.html>


More information about the Kde-windows mailing list