Review Request 118039: Simplify KConfig::readEntry/writeEntry

[Matthew Dawson]

> On May 7, 2014, 2:12 p.m., Matthew Dawson wrote:
> > Does anyone know the purpose of the *Check functions in the first place?  The change generally seems fine to me otherwise, I'm just not aware of the code history, and git doesn't reveal anything interesting, and I want to avoid rebraking a past fixed issue.
> 
> Thomas Braxton wrote:
>     They were added during the merge before 4.0, no idea why. I didn't write them that way.

Figured as much.  That shouldn't stop this change from going in.  Any breakage will be dealt with as need :)


> On May 7, 2014, 2:12 p.m., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, lines 168-578
> > <https://git.reviewboard.kde.org/r/118039/diff/1/?file=271923#file271923line168>
> >
> >     As below, is this relevant to the simplification?
> 
> Thomas Braxton wrote:
>     yes, they were always supposed to be member functions

Ok, sounds good.  If the global functions are being deprecated, can you also mark them as such please?  I don't think a SIC is worth that change at this point.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118039/#review57518
-----------------------------------------------------------


On May 7, 2014, 2:25 p.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118039/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This simplifies template<> readEntry/writeEntry by removing unnecessary *Check functions.
> Added kdewin because iirc there was a problem compiling on windows.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 2768318 
>   src/core/kconfiggroup.h 1bcce58 
> 
> Diff: https://git.reviewboard.kde.org/r/118039/diff/
> 
> 
> Testing
> -------
> 
> all tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140507/06fbfb3e/attachment-0001.html>