Review Request 117965: use the correct global variables

[Alex Merry]

> On May 3, 2014, 10:10 a.m., Alex Merry wrote:
> > kde-modules/KDECMakeSettings.cmake, lines 170-176
> > <https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170>
> >
> >     Now the comment doesn't match the code - which is correct?
> 
> Patrick Spendrin wrote:
>     The fix here is that RUNTIME_OUTPUT_DIRECTORY -> CMAKE_RUNTIME_OUTPUT_DIRECTORY because the first one is a target property and not a global variable. I also modified the CMAKE_ARCHIVE|LIBRARY_OUTPUT_DIRECTORY's values, but that isn't strictly required.
> 
> Patrick von Reth wrote:
>     yes but you install the dll to ${CMAKE_BINARY_DIR}/lib
>     
>     "  set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")"
> 
> Patrick Spendrin wrote:
>     No, the dll is RUNTIME so it goes into /bin.
> 
> Alex Merry wrote:
>     Well, I would view the comment as misleading, then. The code isn't combining the executable and dll locations, CMake does that anyway.
> 
> Patrick Spendrin wrote:
>     I modified the comment now, as I said before, this has nothing to do with whether dlls or exes end up anywhere, but that both currently are in the default location (CMAKE_CURRENT_BINARY_DIR) and not in one location as it is needed to run unittests etc. without modifying the path.

You appear to have changed the description of the RR but not the comment in the code...


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
-----------------------------------------------------------


On May 3, 2014, 3:35 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117965/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 3:35 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> use the correct global variables CMAKE_[RUNTIME|ARCHIVE|LIBRARY]_OUTPUT_DIRECTORY. dlls and executables are built into the bin subdir and import & static libraries and plugins end up in the lib subdir of the build directory.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 
> 
> Diff: https://git.reviewboard.kde.org/r/117965/diff/
> 
> 
> Testing
> -------
> 
> windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140503/32cc92bb/attachment.html>