Review Request 118852: [kconfig] Fix build on Visual C++ 2010

Nicolás Alvarez nicolas.alvarez at gmail.com
Mon Jun 30 01:19:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852/
-----------------------------------------------------------

(Updated June 30, 2014, 1:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kconfig


Description
-------

Visual C++ 2010 throws an internal compiler error trying to compile kconfigtest, since 5f4dc2973f. I couldn't figure out a non-intrusive code tweak that would work around the ICE, so I had to skip compiling this particular initialization code on this particular compiler version, and skip running the test that relies on it (testEnums).

The dummy=42 entry is so that the config group isn't empty, which makes testGroupCopyTo and testReparent still run and pass.


Diffs
-----

  autotests/kconfigtest.cpp a8482b7 

Diff: https://git.reviewboard.kde.org/r/118852/diff/


Testing
-------

Compiles on MSVC2010, kconfigtest passes (with testEnums skipped).

I haven't tried compiling on other compilers.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140630/6e7daad7/attachment.html>


More information about the Kde-windows mailing list