Review Request 118935: Added missing battery methods, fixed some issues and removed dead code

Patrick von Reth vonreth at kde.org
Sun Jun 29 15:59:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118935/
-----------------------------------------------------------

(Updated June 29, 2014, 3:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdewin and Solid.


Repository: solid


Description
-------

Added missing methods in winbattery.
Removed dead code.
Fixed some units.
A small cleanup.


Diffs
-----

  src/solid/devices/backends/win/winbattery.h 586eacfece0b1ae3a817f82fd02c0abd40d6dbc5 
  src/solid/devices/backends/win/winbattery.cpp edbb855350350a4479385a438d038348c1950f20 
  src/solid/devices/backends/win/windevicemanager.h 8a0ec62f07e45841c23723e3150a924270784e90 

Diff: https://git.reviewboard.kde.org/r/118935/diff/


Testing
-------

Tested on windows 8 with one battery, I was unable to test the temperature because it is not supported by my battery.


Thanks,

Patrick von Reth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140629/3f1b6454/attachment.html>


More information about the Kde-windows mailing list