Review Request 118935: Added missing battery methods, fixed some issues and removed dead code

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118935/#review61127
-----------------------------------------------------------

Ship it!


Looks good!

You might want to change the comments of the non implemented methods to //TODO: so it appears on development tools, but other than that it looks ok!

- Àlex Fiestas


On June 25, 2014, 12:54 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118935/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 12:54 p.m.)
> 
> 
> Review request for kdewin and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> Added missing methods in winbattery.
> Removed dead code.
> Fixed some units.
> A small cleanup.
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/backends/win/winbattery.h 586eacfece0b1ae3a817f82fd02c0abd40d6dbc5 
>   src/solid/devices/backends/win/winbattery.cpp edbb855350350a4479385a438d038348c1950f20 
>   src/solid/devices/backends/win/windevicemanager.h 8a0ec62f07e45841c23723e3150a924270784e90 
> 
> Diff: https://git.reviewboard.kde.org/r/118935/diff/
> 
> 
> Testing
> -------
> 
> Tested on windows 8 with one battery, I was unable to test the temperature because it is not supported by my battery.
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140628/def70b3b/attachment.html>