Review Request 119313: Fix export header usage in gpgme++ (Windows build)

Andre Heinecke aheinecke at intevation.de
Wed Jul 16 11:22:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119313/
-----------------------------------------------------------

Review request for kdewin and Stephen Kelly.


Repository: kdepimlibs


Description
-------

GPGME does not build completly different libraries but rather 5
variants that only differ in the context but use the same sources
and export the same symbols otherwise.
commit f8d8a1d64aab678b5fd380d5b9e85b6729d90cc0
introduced the usage of generate_export_header for all those
variants although it did not change the sources to actually
use those export headers / macros.

Previously all variants used gpgme++_export.h and defined
MAKE_GPGME___LIB to correctly select the export setting.

We now fall back on that behavior by defining gpgmepp_EXPORTS
when building the variants.

The dependency to GPGME_VANILLA_FOUND for all variants was
already there as the gpgme++_export.h header was installed
unconditionally.


Diffs
-----

  gpgme++/CMakeLists.txt 7cc551e 

Diff: https://git.reviewboard.kde.org/r/119313/diff/


Testing
-------

Compiled gpgme++ from KDE 4.13 on Windows and built kdepim against it.


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140716/4d964562/attachment.html>


More information about the Kde-windows mailing list