Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/#review62197
-----------------------------------------------------------



src/kdecore/k3resolver.h
<https://git.reviewboard.kde.org/r/119249/#comment43230>

    Issue 1: Same as the above.



src/kdecore/k3resolver.h
<https://git.reviewboard.kde.org/r/119249/#comment43231>

    Issue 1: Same as the above.



src/kdemacros.h.cmake
<https://git.reviewboard.kde.org/r/119249/#comment43229>

    Issue 1: Use the mechanism discussed here
    
    http://lists.kde.org/?l=kde-core-devel&m=113126965312032&w=2
    
    to workaround the full template instantiation issue.



src/kdeui/kapplication.cpp
<https://git.reviewboard.kde.org/r/119249/#comment43232>

    Issue 2: "kaboutdata.h" has a forward declaration for being able to declare the namespaced KCrash::defaultCrashHandler as a friend.
    
    This is OK until it is included before "kcrash.h". MSVC will cosider the first seen declaration (without the export) and will consider the one in "kcrash.h" a redefinition with different linkage.
    
    Please note that this is actually not a KDELibs4Support issue but a KCoreAddons and KCrash interoperability on MSVC issue.



src/kdeui/keditlistbox.h
<https://git.reviewboard.kde.org/r/119249/#comment43233>

    Issue 5: Nested classes need to be exported to be usable from outside the library (in this case a test).



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43234>

    Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx
    
    Member methods of exported classes should not be exported explicitly.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43235>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43236>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43237>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43238>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43239>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43240>

    Issue 3: Same as the above.



src/kio/netaccess.h
<https://git.reviewboard.kde.org/r/119249/#comment43241>

    Issue 3: Same as the above.



tests/kprintpreview_test.cpp
<https://git.reviewboard.kde.org/r/119249/#comment43242>

    Issue 4: QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885
    
    q:\kdelibs4support\tests\kprintpreview_test.cpp(58) : error C2308: concatenating mismatched strings
            Concatenating wide "Lorem ipsum dolor sit amet, consectetur adipiscing elit. " with narrow "Nam malesuada massa dolor, sed sollicitudin turpiscongue eu. Pellentesque ac risus felis. Etiam scelerisque "
    
    It's just a test, do we really need QStringLiteral?


- Cristian Oneț


On Iulie 12, 2014, 5:02 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119249/
> -----------------------------------------------------------
> 
> (Updated Iulie 12, 2014, 5:02 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them.
> 
> That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them).
> 
> Here is a list of issues:
> 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry'
> 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage
> 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface
> 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885
> 5. KEditListBox::CustomEditor linker error caused by missing export
> 
> 
> Diffs
> -----
> 
>   autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 
>   src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd 
>   src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 
>   src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe 
>   src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 
>   src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f 
>   tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 
> 
> Diff: https://git.reviewboard.kde.org/r/119249/diff/
> 
> 
> Testing
> -------
> 
> Build with msvc2013 on Windows and gcc-4.8.3 on Linux.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140712/1fc4ec25/attachment-0001.html>