Review Request 119000: [analitza] Set the needed macros for math.h to provide M_PI on Windows

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119000/#review61767
-----------------------------------------------------------

Ship it!


Maybe it would make sense to move it to ECM?

- Aleix Pol Gonzalez


On July 7, 2014, 12:21 a.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119000/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 12:21 a.m.)
> 
> 
> Review request for KDE Edu and kdewin.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Set the needed macros for math.h to provide M_PI on Windows
> 
> MSVC needs _USE_MATH_DEFINES:
> See http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx
> 
> And MinGW needs either _BSD_SOURCE or _GNU_SOURCE.
> 
> 
> Diffs
> -----
> 
>   analitzaplot/CMakeLists.txt 08e8990 
> 
> Diff: https://git.reviewboard.kde.org/r/119000/diff/
> 
> 
> Testing
> -------
> 
> Builds on MSVC2013 and MinGW4.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140707/5d3bf02a/attachment.html>