[kate] [Bug 243375] [PATCH] KDevelop crashes since KGlobal is deleted after KZoneAllocator is freed due to wrong behavior of KateFactory. Fixed.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=243375

--- Comment #6 from Kevin Funk <kevin at kfunk.org> ---
Git commit 8beb63bcb08568eac8578844d7a1f4f44280f685 by Kevin Funk.
Committed on 11/12/2013 at 09:48.
Pushed by kfunk into branch 'master'.

Attempt to fix KZoneAllocator issue

kcompletion.p_h: Make the static KZoneAllocator member of KCompTreeNode
a shared pointer so external users can hold a reference to it.

kcompletion.cpp: Hold a reference to KCompTreeNode's KZoneAllocator
instance so we avoid deleting the KZoneAllocator too early. See attached
bug report for possible causes. (Hint: It crashes on Windows because
~KZoneAllocator is called to early.)

kallocator.cpp: Use printf instead of qDebug(), because this code path
code might be called very late during destruction and qDebug() will
crash deep inside Qt.

Also see discussion:
http://lists.kde.org/?l=kde-devel&m=138583383708455&w=1
Related: bug 327599
REVIEW: 114715

M  +5    -3    kdecore/util/kallocator.cpp
M  +4    -1    kdeui/util/kcompletion.cpp
M  +11   -3    kdeui/util/kcompletion_p.h

http://commits.kde.org/kdelibs/8beb63bcb08568eac8578844d7a1f4f44280f685

-- 
You are receiving this mail because:
You are on the CC list for the bug.