Review Request 115107: Link tests to kritaimage instead of using directly its sources

Andrius da Costa Ribas andriusmao at gmail.com
Thu Jan 23 20:18:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115107/
-----------------------------------------------------------

(Updated Jan. 23, 2014, 8:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
-------

Avoid conflicts on MinGW since these sources refer to headers where the classes are "dllimport" (since at this point we are not building the library).

Obs.: This is not the case for the next targets in this CMake file, since kis_tile_data is not exported.


Diffs
-----

  krita/image/tiles3/tests/CMakeLists.txt 5339543 

Diff: https://git.reviewboard.kde.org/r/115107/diff/


Testing
-------

Builds on both MinGW and MSVC.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140123/5ac7ab14/attachment-0001.html>


More information about the Kde-windows mailing list