Review Request 115109: _isnan is present only in MSVC's <cfloat>, for MinGW we still use std::isnan

Thorsten Zachmann t.zachmann at zagge.de
Sun Jan 19 06:13:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115109/#review47665
-----------------------------------------------------------

Ship it!


Ship It!

- Thorsten Zachmann


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115109/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:42 a.m.)
> 
> 
> Review request for Calligra and kdewin.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix building on MinGW since we only need the additional header and define for MSVC. Also changed "math.h" and "float.h" to "cmath" and "cfloat".
> 
> 
> Diffs
> -----
> 
>   krita/image/brushengine/kis_paintop.cc 304317a 
> 
> Diff: https://git.reviewboard.kde.org/r/115109/diff/
> 
> 
> Testing
> -------
> 
> Tested building on MSVC and MinGW
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140119/8a8b7590/attachment.html>


More information about the Kde-windows mailing list