Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

Albert Astals Cid aacid at kde.org
Sat Jan 11 14:52:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/#review47190
-----------------------------------------------------------



src/backends/python2/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114964/#comment33643>

    Shouldn't this go into the kdewin include files then?


- Albert Astals Cid


On Jan. 11, 2014, 2:37 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114964/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 2:37 p.m.)
> 
> 
> Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> This typedef is in both kdewin's sys/types (msvc/include) and python config headers. By adding this definition the typedef present in kdewin is skipped.
> 
> 
> Diffs
> -----
> 
>   src/backends/python2/CMakeLists.txt d27d88f 
> 
> Diff: https://git.reviewboard.kde.org/r/114964/diff/
> 
> 
> Testing
> -------
> 
> Python backend builds and run fine from a clean MSVC build.
> MinGW build was already okay, as per http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140111/17f97306/attachment.html>


More information about the Kde-windows mailing list