Review Request 115745: kservice: Allow compiling with MSVC

David Faure faure at kde.org
Sun Feb 16 23:11:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115745/#review50002
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 14, 2014, 12:30 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115745/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:30 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Allow compiling with MSVC
> 
> unistd.h -> qplatformdefs.h + use QUrlQuery
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bd256eb01d50dc9f1c5bd62f79e519a381046164 
>   src/kbuildsycoca/kbuildsycoca.cpp 22b95155edbc0e5bfff7a2e636a00ac8e5cf85db 
>   src/kdeinit/ktoolinvocation_win.cpp de50e83b66fb6d9f84696c106c1d3c1d75cde62f 
>   src/plugin/kpluginloader.cpp e4f70fc87d563151ee34e8e69c54a0d47afb60c8 
>   src/services/kservice.cpp d8ea9554474975f131b8bfc400d035d864added6 
> 
> Diff: https://git.reviewboard.kde.org/r/115745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140216/3797d987/attachment.html>


More information about the Kde-windows mailing list