Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

Martin Gräßlin mgraesslin at
Thu Feb 13 06:53:41 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks, kdewin and Marco Martin.

Repository: knotifications


Remove #if HAVE_X11 blocks from kstatusnotifieritem

They are all only around kwindowsystem framework usage which is not
needed to have in ifdefs. The runtime usage might differ, but from
looking at each line of code it works correctly. It's mostly about
virtual desktops and thus calls are simply ignored on systems not
supporting virtual desktops.


  src/kstatusnotifieritem.cpp 82c4e65e1869fe00432634bcabbf410d44e4a80a 




Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-windows mailing list