Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

Nicolás Alvarez nicolas.alvarez at gmail.com
Fri Dec 12 13:56:23 UTC 2014



> On Nov. 9, 2014, 9:52 p.m., Alexander Richardson wrote:
> > When I originally got KF5 to compile on windows I seem to remember having to do this a few times manually as well.
> > 
> > Would it make sense to add the macro to KCoreAddons?

KDEPimLibs also depends on this macro in several places.


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70152
-----------------------------------------------------------


On Nov. 8, 2014, 7:26 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121080/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 7:26 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not available. Implement it instead.
> 
> 
> Diffs
> -----
> 
>   lib/konq/src/konq_historyentry.h de34d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/121080/diff/
> 
> 
> Testing
> -------
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20141212/53a638e1/attachment.html>


More information about the Kde-windows mailing list