Review Request 117845: rename test as another exists with the same name

Patrick Spendrin ps_ml at gmx.de
Tue Apr 29 11:03:05 UTC 2014



> On April 29, 2014, 10:53 a.m., Vishesh Handa wrote:
> > src/file/tests/CMakeLists.txt, line 30
> > <https://git.reviewboard.kde.org/r/117845/diff/2/?file=269061#file269061line30>
> >
> >     I'm sorry. Could you do it the other way around?
> >     
> >     Keep the executable name - basicindexingqueuetest, and set the target name whatever you want?
> >     
> >     Feel free to commit it after that.

Hm, that is original problem: then I have two executables of the same name, and on windows they will be in the same directory (CMAKE_BINARY_DIR/bin) so overwriting each other. 


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56842
-----------------------------------------------------------


On April 29, 2014, 12:01 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 12:01 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> rename test as another exists with the same name
> 
> 
> Diffs
> -----
> 
>   src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 
> 
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
> 
> 
> Testing
> -------
> 
> msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140429/4cdfa74f/attachment.html>


More information about the Kde-windows mailing list