Review Request 117832: use QFileInfo to also find hidden paths on windows

[Patrick Spendrin]

> On April 28, 2014, 1:24 p.m., Reece Dunn wrote:
> > The *A Windows API variants use the ASCII (referred to as ANSI in the Windows docs), not UTF-8, encoding. Therefore, this will not work as expected for non-ASCII characters. This should use SetFileAttributeW with toUtf16.

The files used in the test use ascii encoding though, so it works.
I'll change it anyway though.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56750
-----------------------------------------------------------


On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117832/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 10:05 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> hidden files on windows must not start with a . So instead use QFileInfo to correctly check that files are hidden and also modify the test and use the native function.
> 
> 
> Diffs
> -----
> 
>   src/file/autotest/fileindexerconfigutils.h ab52f3b 
> 
> Diff: https://git.reviewboard.kde.org/r/117832/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140428/8081a0e7/attachment.html>