Review Request 117827: malloc_trim is a gnu extension

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/#review56740
-----------------------------------------------------------

Ship it!


I was trying to keep the memory used by the process to a minimum and in this particular case free would not return the memory back to the kernel, hence the explicit trim command. Ship it for now. Maybe we want to use a better solution in the future.

- Vishesh Handa


On April 28, 2014, 9:48 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117827/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 9:48 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure what the exact purpose of this call is (is the memory not freed elsewhere?), so I'd like to have some comments on it.
> 
> 
> Diffs
> -----
> 
>   src/xapian/xapiandatabase.cpp 0478139 
> 
> Diff: https://git.reviewboard.kde.org/r/117827/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140428/670e15df/attachment-0001.html>