Review Request 117162: Fix for emerging qt5 non-qtbase modules

Patrick von Reth vonreth at kde.org
Sun Apr 6 12:21:54 UTC 2014



> On March 31, 2014, 2:59 p.m., Patrick von Reth wrote:
> > Ship It!

http://quickgit.kde.org/?p=emerge.git&a=commit&h=c8cd0b490522b89bfc9bfd481b88ab5cb8a887e4


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117162/#review54694
-----------------------------------------------------------


On March 29, 2014, 8:01 p.m., Michael Hansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117162/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 8:01 p.m.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> QMake gets compiled with its prefix hard-coded into the executable on Windows...  The existing hack to fix install prefixes caused the other qt5 modules to fail to compile, since qmake is reporting that Qt is installed on the drive root (e.g. using c:/bin instead of c:/KDE/bin).
> 
> This change fixes qmake by allowing it to compile with the proper prefix, and then moving the installed files from the incorrectly prefixed subdirectory within the image dir to the root of the image dir.
> 
> 
> Diffs
> -----
> 
>   bin/BuildSystem/Qt5CoreBuildSystem.py efc9d394e7305a7e1ff5bb3925b3662d6db1971a 
>   portage/libs/qt5/qtbase/qtbase-20120411.py 83e88c4e74084e9131856762c91ab3100df17b45 
> 
> Diff: https://git.reviewboard.kde.org/r/117162/diff/
> 
> 
> Testing
> -------
> 
> Built qtbase and qtscript with the updated scripts, on MSVC2013.
> 
> 
> Thanks,
> 
> Michael Hansen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140406/2da58c9f/attachment.html>


More information about the Kde-windows mailing list