Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

Ralf Habacker ralf.habacker at freenet.de
Fri Nov 8 21:57:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112009/#review43284
-----------------------------------------------------------

Ship it!


Because of the icoutils requirement on non windows systems please add a dependency note to https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/README.packagers

Patch looks good otherwise. 



- Ralf Habacker


On Aug. 17, 2013, 3:43 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112009/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:43 p.m.)
> 
> 
> Review request for KDE Runtime, kdewin and Pali Rohár.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This patch intends to enable Windows exe/dll thumbnailing by using winapi. It derives from the unsubmitted patch from Pali Rohár from https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few adjustments on the original patch, split that patch into a common part and a icoutils-specific part, and then created the winapi-based part to replace the icoutils one on Windows (porting icoutils to windows wasn't going to be easy).
> 
> 
> Diffs
> -----
> 
>   kioslave/thumbnail/CMakeLists.txt b81339b 
>   kioslave/thumbnail/icoutils.h 6468bc1 
>   kioslave/thumbnail/icoutils.cpp 31db85d 
>   kioslave/thumbnail/icoutils_common.cpp PRE-CREATION 
>   kioslave/thumbnail/icoutils_win.cpp PRE-CREATION 
>   kioslave/thumbnail/icoutils_wrestool.cpp PRE-CREATION 
>   kioslave/thumbnail/windowsexecreator.h a407982 
>   kioslave/thumbnail/windowsexecreator.cpp 9e24aee 
>   kioslave/thumbnail/windowsexethumbnail.desktop f10efef 
>   kioslave/thumbnail/windowsimagecreator.h 0b68cc6 
>   kioslave/thumbnail/windowsimagecreator.cpp 08b063d 
> 
> Diff: http://git.reviewboard.kde.org/r/112009/diff/
> 
> 
> Testing
> -------
> 
> Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
> Tested using ico files and both 32-bit and 64-bit executables and dlls, including jumbo-size icons.
> I've used QLibrary for all winapi functions in order to avoid issues with MinGW compiler, but I don't have a MinGW setup to check.
> 
> Not tested on *nix, but the original patch was not changed except for iterating order in the common part and namespacing.
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20131108/2d304c98/attachment-0001.html>


More information about the Kde-windows mailing list