Review Request 110462: Call new Instance dbus method on Windows when a KUniqueApplication is already running

[Andre Heinecke]

> On May 27, 2013, 9:05 a.m., Patrick Spendrin wrote:
> > kdeui/kernel/kuniqueapplication.cpp, line 181
> > <http://git.reviewboard.kde.org/r/110462/diff/1/?file=144280#file144280line181>
> >
> >     Why do we still fail this function (exit(255)), even if we actually are still doing a meaningful action (activateWindowForProcess) here?

The activateWindowForProcess did not work in my test cases because the calling process usually does not have the right to activate the Window, I think.
But I was unsure if there is any case in which it can work so I left it in with the old return value as a fallback.
As this code means we could not start a new Process and could not communicate with the old one and we can't be sure if the activateWindowForProcess worked I think returning with an error is the proper behavior.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110462/#review33192
-----------------------------------------------------------


On May 16, 2013, 10:21 a.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110462/
> -----------------------------------------------------------
> 
> (Updated May 16, 2013, 10:21 a.m.)
> 
> 
> Review request for kdelibs, kdewin, Patrick Spendrin, and Patrick von Reth.
> 
> 
> Description
> -------
> 
> Currently when a second instance of a KUniqueApplication is created KUniqueapplication on Windows just tries to bring the existing process to the front. The problem with this is that the commandline arguments are lost. Kontact parts of kdepim solved this problem in pimuniqueapplication by calling NewInstance with the correct parameters on the existing application.
> This review Request is about adding that code from kdepimlibs/kontactinterface/pimuniqueapplication.cpp also to KUniqueapplication on Windows.
> 
> 
> This addresses bug 258489.
>     http://bugs.kde.org/show_bug.cgi?id=258489
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kuniqueapplication.cpp 777fc35 
> 
> Diff: http://git.reviewboard.kde.org/r/110462/diff/
> 
> 
> Testing
> -------
> 
> Tested with Kleopatra on Windows.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20130527/16341dfc/attachment-0001.html>