Review Request 109496: Make kdev-php compile under MinGW64

Laszlo Papp lpapp at kde.org
Sat Mar 16 02:22:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109496/#review29306
-----------------------------------------------------------


Could you please write a meaningful commit message for the fix? For instance, the root cause of the issue should be mentioned, and not just the "Fix foo" so that an average commit reader can understand without investigation much about the code change. Thank you.

- Laszlo Papp


On March 15, 2013, 2:38 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109496/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 2:38 p.m.)
> 
> 
> Review request for KDevelop, kdewin and Niko Sams.
> 
> 
> Description
> -------
> 
> some CMake hacks to make "emerge kdev-php" work with mingw64 / Windows 7
> 
> 
> Diffs
> -----
> 
>   completion/CMakeLists.txt c38490d 
>   completion/tests/CMakeLists.txt 5ba0c48 
>   duchain/CMakeLists.txt 241fd69 
>   duchain/tests/CMakeLists.txt 8fb3f94 
>   parser/CMakeLists.txt f66bf09 
>   parser/test/CMakeLists.txt f9307b8 
> 
> Diff: http://git.reviewboard.kde.org/r/109496/diff/
> 
> 
> Testing
> -------
> 
> "emerge kdev-php" finished successfully.
> I now have PHP support in KDevelop on my Windows machine :-)
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20130316/399ee6fd/attachment.html>


More information about the Kde-windows mailing list